feat(kafka-deduplicator): add checksum to checkpoint tracking, handle incremental retention #39917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
eli-r-ph
force-pushed
the
eli.r/kdedup-cp-plan-checksums
branch
from
11dc521 to
16581bb
Compare
jose-sequeira
approved these changes
Oct 21, 2025
eli-r-ph
force-pushed
the
eli.r/kdedup-cp-plan-checksums
branch
from
aecfb8e to
0508c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to track all the files we need to reconstitute a complete RocksDB store for reimport while minimizing uploads to remote storage across many incremental checkpoints, we'll need to include file checksums and use them in the decision to upload files present in each incremental checkpoint. The rules are different for SST vs. non-SST store file types.
Changes
How did you test this code?
Locally and in CI
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Changelog: (features only) Is this feature complete?
No update required