fix: remove basic mode for saved insights #39915
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, saved insights are fetched in basic mode which is faster but contains a smaller payload. On the initial fetch, the insights won't contain the
resultskey which is used when rendering the visualizations. Since the result is cached, when a user tries to swicth to Card layout on the product analytics tab, it uses the cached result which doesn't contain the results causing the empty state to be rendered.On refresh, this issue doesn't exist since there's no initial cache state, and the
dataNodeLogicresponse loader forces a refresh of each insight individuallyCloses #39703
Changes
Removes basic mode for saved insights rendered on the Product analytics page
How did you test this code?