Skip to content

Conversation

@ndaba1
Copy link
Contributor

@ndaba1 ndaba1 commented Oct 17, 2025

Problem

Currently, saved insights are fetched in basic mode which is faster but contains a smaller payload. On the initial fetch, the insights won't contain the results key which is used when rendering the visualizations. Since the result is cached, when a user tries to swicth to Card layout on the product analytics tab, it uses the cached result which doesn't contain the results causing the empty state to be rendered.

On refresh, this issue doesn't exist since there's no initial cache state, and the dataNodeLogic response loader forces a refresh of each insight individually

Closes #39703

Changes

Removes basic mode for saved insights rendered on the Product analytics page

How did you test this code?

  • Go to the product analytics page
  • Switch to card layout
  • The visualizations should be rendered correctly without having to refresh the page

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@ndaba1
Copy link
Contributor Author

ndaba1 commented Oct 27, 2025

hey @clr182
Could you help get this reviewed

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Graphs not rendering on navigation

3 participants