Skip to content

Conversation

@adamleithp
Copy link
Contributor

@adamleithp adamleithp commented Oct 17, 2025

Problem

2025-10-17 23 48 03

  • rounded top and bottom of active tab was different
  • X button in tab didn't have hover state nor triggered hover in the tab itself, making it seem broken

Changes

Active tab get's bigger rounded top

  • tab button bigger rounded
    x button on tab now triggering hover state on tab itself

2025-10-17 23 52 49

How did you test this code?

Locally

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 16)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Size Change: 0 B

Total Size: 3.3 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.3 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 3)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@adamleithp adamleithp merged commit 19d94f6 into master Oct 20, 2025
127 of 128 checks passed
@adamleithp adamleithp deleted the ux/scene-tabs-love-3 branch October 20, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants