-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(customers): Summarize sessions individually #39909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Size Change: +134 B (0%) Total Size: 3.3 MB ℹ️ View Unchanged
|
Greptile encountered an error while reviewing this PR. Please reach out to [email protected] for assistance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great. good testing and nice screenshots too. left one very minor comment
<span>{formatDuration(segment.meta?.duration || 0)}</span> | ||
</div> | ||
|
||
{keyActions && keyActions.events && keyActions.events.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{keyActions && keyActions.events && keyActions.events.length > 0 && ( | |
{keyActions?.events && keyActions.events.length > 0 && ( |
Problem
Button isn't really working, as it hits the endpoint to summarize multiple sessions passing in too few sessions. This leads to no patterns being identified and basically no value.
Instead, we should be summarizing the sessions individually, as the person feed only shows up to a handful of sessions at a time, and breaking down the summaries by session.
Closes #38941
Changes
UI components are a bit raw still, there are a lot of points to be improved. Hyperlinking exceptions to error tracking, link to specific segments of session replay, events, etc.
Loading state
Error state
Summary ready
Expanded summary and segment
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Changelog: (features only) Is this feature complete?