feat(workflows): add activity log event property filters #39904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| options: [ | ||
| { name: 'All internal events', value: null }, | ||
| ...getInternalEventFilterOptions('standard').map((item) => ({ | ||
| ...getInternalEventFilterOptions('activity-log').map((item) => ({ |
Contributor
There was a problem hiding this comment.
style: Verify 'standard' context isn't used elsewhere for internal events, or if this change should apply globally to all standard contexts.
Prompt To Fix With AI
This is a comment left during a code review.
Path: frontend/src/lib/components/TaxonomicFilter/taxonomicFilterLogic.tsx
Line: 291:291
Comment:
**style:** Verify `'standard'` context isn't used elsewhere for internal events, or if this change should apply globally to all standard contexts.
How can I resolve this? If you propose a fix, please make it concise.
Contributor
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Contributor
|
Size Change: +502 B (+0.02%) Total Size: 3.3 MB ℹ️ View Unchanged
|
Contributor
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
…ostHog/posthog into feat/internal-event-properties
meikelmosby
approved these changes
Oct 20, 2025
daibhin
reviewed
Oct 20, 2025
…/internal-event-properties
daibhin
approved these changes
Oct 20, 2025
…/internal-event-properties
…ostHog/posthog into feat/internal-event-properties
Contributor
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Contributor
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#39689 added hardcoded internal events for team 2, but that doesn't help with filtering on internal event properties. The tricky thing is these aren't currently integrated into event definitions or into posthog events in general, so we can't really load them dynamically in the filters
Changes
Adds relevant activity log event properties that are used in this Replay workflow currently
How did you test this code?
Validated locally