fix: only reload query when events are added / changed (not all removed)

[daibhin]

Problem

Addresses all the feedback in https://posthog.slack.com/archives/C07AA937K9A/p1759420827044679

Changes

• Do not re-run query if all events are removed
• All persistent state to url

[github-actions]

Size Change: 0 B

Total Size: 3.3 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	3.3 MB

_{compressed-size-action}

[greptile-apps]

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: potential desync if URL parameter is manually removed

the condition only checks if params.events exists, so if a user has events selected and then manually removes the events param from the URL, the state won't reset to null. consider handling the undefined case:

Suggested change

	if (params.events && !equal(params.events, values.events)) {
	actions.setEvents(params.events)
	}
	if (!equal(params.events ?? null, values.events)) {
	actions.setEvents(params.events ?? null)
	}

Prompt To Fix With AI

This is a comment left during a code review.
Path: products/error_tracking/frontend/scenes/ErrorTrackingScene/tabs/impact/errorTrackingImpactListLogic.tsx
Line: 128:130

Comment:
**style:** potential desync if URL parameter is manually removed

the condition only checks if `params.events` exists, so if a user has events selected and then manually removes the `events` param from the URL, the state won't reset to `null`. consider handling the undefined case:

```suggestion
            if (!equal(params.events ?? null, values.events)) {
                actions.setEvents(params.events ?? null)
            }
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

style: potential desync if URL parameter is manually removed

the condition only checks if params.activeTab exists, so if someone manually removes the activeTab param from the URL, the state won't reset to the default. consider handling the undefined case:

Suggested change

	if (params.activeTab && !equal(params.activeTab, values.activeTab)) {
	actions.setActiveTab(params.activeTab)
	}
	if (!equal(params.activeTab ?? DEFAULT_ACTIVE_TAB, values.activeTab)) {
	actions.setActiveTab(params.activeTab ?? DEFAULT_ACTIVE_TAB)
	}

Prompt To Fix With AI

This is a comment left during a code review.
Path: products/error_tracking/frontend/scenes/ErrorTrackingScene/errorTrackingSceneLogic.ts
Line: 137:139

Comment:
**style:** potential desync if URL parameter is manually removed

the condition only checks if `params.activeTab` exists, so if someone manually removes the `activeTab` param from the URL, the state won't reset to the default. consider handling the undefined case:

```suggestion
            if (!equal(params.activeTab ?? DEFAULT_ACTIVE_TAB, values.activeTab)) {
                actions.setActiveTab(params.activeTab ?? DEFAULT_ACTIVE_TAB)
            }
```

How can I resolve this? If you propose a fix, please make it concise.