-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Surveys): Task to update rollout percentage for Adaptive Collection #26197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phanatic
changed the title
Survey adaptive sampling flag
feat(Surveys): Task to update rollout percentage for Adaptive Collection
Nov 14, 2024
dmarticus
approved these changes
Nov 14, 2024
Phanatic
force-pushed
the
survey-adaptive-sampling-flag
branch
from
November 14, 2024 19:11
c13b8b1
to
da6b8c2
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves : #25722
We currently allow %-based rollouts for surveys, as well as the option to set a response limit.
For some users with high volumes, that's not enough. Here is what we've heard:
Being able to specify a response limit per time period, e.g. "250 responses per month", or "7 responses per day"
Ideally, PostHog would adapt the rollout of surveys across the time period specified by the user, e.g. when a user wants 250 responses over a one-month period, we make sure they receive approximately 8 responses per day
Changes
Celery task for daily rollout updates
Created a Celery task to update the rollout percentage of a linked targeting_feature_flag based on the calculated response_sampling_daily_limits.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Celery task: