Fix: The demo video is the wrong size in docs #13187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+24
to
+25
| width="600" | ||
| height="337" |
There was a problem hiding this comment.
style: hardcoded dimensions make the video non-responsive on smaller screens - other YouTube iframes in the docs don't use explicit dimensions (see retention.mdx:11-14, funnels.mdx:46-49, trends/overview.mdx:47-50)
Prompt To Fix With AI
This is a comment left during a code review.
Path: contents/docs/product-analytics/dashboards.mdx
Line: 24:25
Comment:
**style:** hardcoded dimensions make the video non-responsive on smaller screens - other YouTube iframes in the docs don't use explicit dimensions (see retention.mdx:11-14, funnels.mdx:46-49, trends/overview.mdx:47-50)
How can I resolve this? If you propose a fix, please make it concise.
edwinyjlim
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
This works, but like @joethreepwood said, we'd have to apply these fixes to every <iframe> youtube embed
Comment on lines
23
to
+25
| className="rounded shadow-xl" | ||
| width="600" | ||
| height="337" |
There was a problem hiding this comment.
I'd use tailwind classes for full width and 16:9 aspect ratio, so the video resizes for mobile
The mt-4 is just for spacing (the table of contents and video player touch rn on mobile)
Suggested change
| className="rounded shadow-xl" | |
| width="600" | |
| height="337" | |
| className="rounded shadow-xl mt-4 w-full aspect-video" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Before
After
However, this occurs on many pages and only fixes one. I can role this out further if needed, but I'm pretty sure there'll be a smarter way to do this and that we may be wise to move to Wistia instead.
Checklist
vercel.jsonArticle checklist