Desktop loading indicator #13182
Merged
Desktop loading indicator #13182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| }, 1000) | ||
|
|
||
| return () => clearInterval(interval) | ||
| }, [rendered, currentMessageIndex]) |
There was a problem hiding this comment.
logic: currentMessageIndex in dependencies causes the effect to re-run every time the message changes, recreating the interval unnecessarily. Remove it from the dependency array.
Suggested change
| }, [rendered, currentMessageIndex]) | |
| }, [rendered]) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/components/Desktop/index.tsx
Line: 325:325
Comment:
**logic:** `currentMessageIndex` in dependencies causes the effect to re-run every time the message changes, recreating the interval unnecessarily. Remove it from the dependency array.
```suggestion
}, [rendered])
```
How can I resolve this? If you propose a fix, please make it concise.| import { DebugContainerQuery } from 'components/DebugContainerQuery' | ||
| import HedgeHogModeEmbed from 'components/HedgehogMode' | ||
| import ReactConfetti from 'react-confetti' | ||
| import ProgressBar from 'components/ProgressBar' |
There was a problem hiding this comment.
style: unused import
Suggested change
| import ProgressBar from 'components/ProgressBar' |
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/components/Desktop/index.tsx
Line: 19:19
Comment:
**style:** unused import
```suggestion
```
How can I resolve this? If you propose a fix, please make it concise.
|
@smallbrownbike This now has a cool rotating list of messages, but because even that can get loaded to late, it also injects an initial loading message into Gatsby stuff which does show reliably. Change whatever you want and merge at will. |
This reverts commit 80fffc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a loading state while the site is... loading.