Skip to content

Conversation

rafaeelaudibert
Copy link
Member

Let's display all teams in the profile page rather than just the first one. Most of us are in a single team, but not everyone, let's display that

Let's display all teams in the profile page rather than just the first one. Most of us are in a single team, but not everyone, let's display that
Copy link

vercel bot commented Oct 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
posthog Ready Ready Preview Oct 12, 2025 4:22am

@corywatilo
Copy link
Collaborator

Why not now tabs?

image

@rafaeelaudibert
Copy link
Member Author

Jesus @corywatilo, I alt-tabbed for 2 minutes and you implemented tabs

@rafaeelaudibert
Copy link
Member Author

I was planning on displaying the person in the list because it looks very weird for 1-person teams (like me lol)

image image

Display own person in the list of people on the team so that it doesn't look weird, display it always first
@rafaeelaudibert rafaeelaudibert marked this pull request as ready for review October 11, 2025 23:31
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (2)

  1. src/pages/community/profiles/[id].tsx, line 1085-1089 (link)

    style: unused variable teamCrestMap (the TeamMember component uses useTeamCrestMap() internally)

  2. src/pages/community/profiles/[id].tsx, line 1082 (link)

    style: unused variable team (only used to compute unused teamCrestMap)

No files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@corywatilo
Copy link
Collaborator

See I intentionally didn't cover cases like 1-person teams and people with > teams since Tim is very adamant about these not being a thing but here we are and they're still apparently a thing.

@rafaeelaudibert
Copy link
Member Author

Now you own the power, you either merge this and Tim has to concede solo teams are a thing (cough cough revenue analytics, customer analytics, surveys, cough cough), or you can close this PR and shame me in front of him

@rafaeelaudibert
Copy link
Member Author

rafaeelaudibert commented Oct 17, 2025

@corywatilo just pinging you to take a decision here to avoid me having this outstanding PR open - I'm still at a stage where my open PRs list is manageable lol

I don't want to just merge this, knowing this might have bigger implications on how we think about our teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants