-
Notifications
You must be signed in to change notification settings - Fork 643
feat: Display all teams in profile page #13178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Let's display all teams in the profile page rather than just the first one. Most of us are in a single team, but not everyone, let's display that
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Jesus @corywatilo, I alt-tabbed for 2 minutes and you implemented tabs |
Display own person in the list of people on the team so that it doesn't look weird, display it always first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (2)
No files reviewed, 2 comments
See I intentionally didn't cover cases like 1-person teams and people with > teams since Tim is very adamant about these not being a thing but here we are and they're still apparently a thing. |
Now you own the power, you either merge this and Tim has to concede solo teams are a thing (cough cough revenue analytics, customer analytics, surveys, cough cough), or you can close this PR and shame me in front of him |
@corywatilo just pinging you to take a decision here to avoid me having this outstanding PR open - I'm still at a stage where my open PRs list is manageable lol I don't want to just merge this, knowing this might have bigger implications on how we think about our teams |
Let's display all teams in the profile page rather than just the first one. Most of us are in a single team, but not everyone, let's display that