Skip to content

fix: notify Slack when a release is rejected at the approval gate - #908

Merged
ioannisj merged 2 commits into
mainfrom
fix/release-notify-rejected
Sep 1, 2026
Merged

fix: notify Slack when a release is rejected at the approval gate#908
ioannisj merged 2 commits into
mainfrom
fix/release-notify-rejected

Conversation

@ioannisj

@ioannisj ioannisj commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Release run 33497521635 was rejected at the "Release" environment gate and nothing was posted to Slack. release.yml notifies on approval needed, approved, failed and released, but there is no job for a rejection, so the thread just goes quiet and nobody watching it knows the release was turned down.

This ports the notify-rejected job that every other PostHog SDK already has (ruby, ios, android, js, go, php, dotnet), adapted to this repo. It hangs off version-bump (the job carrying environment: "Release" here), reads the run's /approvals to confirm it was an actual rejection rather than an ordinary failure, and replies in the existing Slack thread with the reviewer's comment when there is one.

Two deliberate differences from the reference files:

  • They pin slack-thread-reply to @main. This repo pins it to a SHA, so the new job reuses the SHA the other four Slack steps here already use.
  • Added permissions: actions: read on the job, which the siblings do not have. The workflow sets contents: read at the top level, so without it the GITHUB_TOKEN carries no actions scope, the gh api .../approvals call 403s, and the job fails with the rejection still silent. Probably worth backporting to the other SDKs.

💚 How did you test it?

There is no way to exercise this end to end without rejecting a real release, so I verified the logic against the run that prompted it, 33497521635:

  • Bump versions and commit to main concluded failure, so the job's if gate fires.
  • GET /actions/runs/33497521635/approvals returns {"state": "rejected", "comment": "", "user": "ioannisj"}, so the check step sets was_rejected=true, and with an empty comment it takes the branch that posts the plain "Release was rejected." message.
  • No double post. version-bump's own "Notify Slack - Failed" step never runs when the gate rejects, because none of that job's steps execute at all.

I also parsed the workflow and confirmed every needs.<job> reference resolves to a job that exists in the file. actionlint is not installed locally, so that check did not run.

Two follow-up fixes after review, both in d6087af:

  • head -1 truncated a multiline rejection comment to its first line. It was there to pick the first rejecting reviewer, not the first line, so it moved into jq as first(...). Worth noting the heredoc below it exists only to carry a multiline value, so with head -1 in front the block could never do anything.
  • The heredoc now uses a random delimiter. Now that multiline comments actually reach it, a comment containing a literal EOF line would close the block early and the rest would be parsed as step outputs.

Verified both by running the step body against five payloads: multiline comment, empty comment (the path the real run took), approved-only, two rejecters, and a comment containing a literal EOF line. The last one now lands as message content instead of setting a separate output key.

All seven sibling SDKs carry the same head -1 and fixed EOF delimiter, so both fixes want backporting.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file

CI-only change with nothing to release, so no changeset.

🤖 Agent context

DRI: @ioannisj
Autonomy: Human-driven (agent-assisted)

@ioannisj ioannisj self-assigned this Sep 1, 2026
@ioannisj
ioannisj marked this pull request as ready for review September 1, 2026 10:51
@ioannisj
ioannisj requested a review from a team as a code owner September 1, 2026 10:51
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

posthog-python Compliance Report

Date: 2026-09-01 11:53:14 UTC
Duration: 256369ms

✅ All Tests Passed!

111/111 tests passed


Capture_V1 Tests

94/94 tests passed

View Details
Test Status Duration
Endpoint And Method.Targets V1 Endpoint 517ms
Endpoint And Method.Does Not Use Legacy Endpoints 511ms
Required Headers.Has Authorization Bearer Header 511ms
Required Headers.Has Content Type Json 510ms
Required Headers.Has Posthog Sdk Info Format 511ms
Required Headers.Has Posthog Attempt Header 509ms
Required Headers.Has Posthog Request Id 510ms
Required Headers.Has Posthog Request Timestamp 510ms
Required Headers.Has User Agent 511ms
Body Format.Body Has Created At And Batch 510ms
Body Format.No Api Key In Body 511ms
Body Format.No Sent At In Body 511ms
Event Format.Event Has Required Root Fields 510ms
Event Format.Event Uuid Is Valid 511ms
Event Format.Event Timestamp Is Rfc3339 510ms
Event Format.Distinct Id Is String 510ms
Event Format.Distinct Id At Root Not Properties 511ms
Event Format.Custom Properties Preserved 510ms
Event Format.Set Properties Preserved 510ms
Event Format.Set Once Properties Preserved 510ms
Event Format.Groups Properties Preserved 510ms
Event Format.Sdk Generates Uuid If Not Provided 510ms
Event Format.Event Has Required Root Fields Batch 514ms
Event Format.Event Uuid Is Valid Batch 514ms
Event Format.Event Timestamp Is Rfc3339 Batch 513ms
Event Format.Distinct Id Is String Batch 514ms
Event Format.Distinct Id At Root Not Properties Batch 513ms
Event Format.Custom Properties Preserved Batch 514ms
Event Format.Set Properties Preserved Batch 513ms
Event Format.Set Once Properties Preserved Batch 514ms
Event Format.Groups Properties Preserved Batch 513ms
Event Format.Sdk Generates Uuid If Not Provided Batch 514ms
Batch Behavior.Multiple Events In Single Batch 517ms
Batch Behavior.Batch Envelope Smoke 515ms
Batch Behavior.Flush With No Events Sends Nothing 507ms
Batch Behavior.Flush At Triggers Batch 1011ms
Batch Behavior.Created At Reflects Batch Creation Time 510ms
Deduplication.Generates Unique Uuids 518ms
Deduplication.Different Events Same Content Different Uuids 512ms
Deduplication.Preserves Uuid On Retry 6520ms
Deduplication.Preserves Timestamp On Retry 6516ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 6523ms
Deduplication.No Duplicate Events In Batch 519ms
Header Behavior On Retry.Attempt Header Starts At One 510ms
Header Behavior On Retry.Attempt Header Increments On Retry 13529ms
Header Behavior On Retry.Request Id Preserved On Retry 6520ms
Header Behavior On Retry.Different Requests Have Different Request Ids 3020ms
Header Behavior On Retry.Request Timestamp Changes On Retry 6516ms
Response Format Validation.Success Response Has Uuid Keyed Results 511ms
Response Format Validation.Success Response Has Ok For Each Event 514ms
Response Format Validation.Success No Retry After When All Ok 513ms
Response Format Validation.Success Retry After Present When Retry Events 1516ms
Response Format Validation.Success No Retry After When Drop Only 513ms
Response Format Validation.Response Echoes Request Id 510ms
Retry Behavior.Retries On 408 6518ms
Retry Behavior.Retries On 500 6520ms
Retry Behavior.Retries On 503 8523ms
Retry Behavior.Retries On 504 6520ms
Retry Behavior.Retryable Errors Have Retry After 3516ms
Retry Behavior.Respects Retry After On Retryable Error 11522ms
Retry Behavior.Does Not Retry On 400 2514ms
Retry Behavior.Does Not Retry On 401 2512ms
Retry Behavior.Does Not Retry On 402 2513ms
Retry Behavior.Does Not Retry On 413 2514ms
Retry Behavior.Does Not Retry On 415 2512ms
Retry Behavior.Non Retryable Errors Have No Retry After 2514ms
Retry Behavior.Implements Backoff 22533ms
Retry Behavior.Max Retries Respected 22537ms
Partial Batch Handling.Handles 200 Full Success 2513ms
Partial Batch Handling.Handles 200 With All Ok 3518ms
Partial Batch Handling.Does Not Retry Dropped Events 3513ms
Partial Batch Handling.Does Not Retry Limited Events 3516ms
Partial Batch Handling.Prunes Ok Events On Partial Retry 6522ms
Partial Batch Handling.Prunes Dropped Events On Partial Retry 6522ms
Partial Batch Handling.Retries Only Retry Events From Partial 6519ms
Partial Batch Handling.Partial Retry Preserves Uuids 6521ms
Partial Batch Handling.Partial Retry Attempt Header Increments 6517ms
Partial Batch Handling.Partial Retry Request Id Preserved 6517ms
Partial Batch Handling.Respects Retry After On Partial 8518ms
Partial Batch Handling.Unknown Result Treated As Terminal 3513ms
Partial Batch Handling.Mixed Ok Drop Limited No Retry 3518ms
Compression.Sends Gzip Content Encoding 511ms
Compression.No Content Encoding When Disabled 510ms
Compression.Compressed Body Is Decompressible 511ms
Error Handling.Does Not Retry On Unknown 4Xx 2510ms
Event Options.Cookieless Mode Override 511ms
Event Options.Disable Skew Correction Override 510ms
Event Options.Process Person Profile Override 511ms
Event Options.Product Tour Id Override 510ms
Event Options.Unset Options Omitted 510ms
Event Options.Options Override In Batch 514ms
Geoip And Historical Migration.Geoip Disable Injected Into Properties 510ms
Geoip And Historical Migration.Historical Migration Set In Body 510ms
Geoip And Historical Migration.Historical Migration Absent By Default 511ms

Feature_Flags Tests

17/17 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 11ms
Request Payload.Flags Request Uses V2 Query Param 9ms
Request Payload.Flags Request Hits Flags Path Not Decide 9ms
Request Payload.Flags Request Omits Authorization Header 9ms
Request Payload.Token In Flags Body Matches Init 9ms
Request Payload.Groups Round Trip 10ms
Request Payload.Groups Default To Empty Object 9ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 9ms
Request Payload.Disable Geoip Omitted Defaults To False 9ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 9ms
Request Lifecycle.No Flags Request On Init Alone 3ms
Request Lifecycle.No Flags Request On Normal Capture 509ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 14ms
Request Lifecycle.Mock Response Value Is Returned To Caller 9ms
Retry Behavior.Retries Flags On 502 313ms
Retry Behavior.Retries Flags On 504 314ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 511ms

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
Prompt To Fix All With AI
### Issue 1
.github/workflows/release.yml:548
**Multiline rejection comments are truncated**

When a reviewer submits a multiline rejection comment, `jq -r` emits physical newlines and `head -1` retains only the first line, causing the Slack reply to omit the rest of the rejection explanation.

```suggestion
            COMMENT=$(echo "$RESPONSE" | jq -r 'first(.[] | select(.state == "rejected") | .comment // empty)')
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix: notify Slack when a release is reje..." | Re-trigger Greptile

Comment thread .github/workflows/release.yml Outdated

@marandaneto marandaneto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bot has a comment otherwise lgtm

@ioannisj
ioannisj enabled auto-merge (squash) September 1, 2026 11:50
@ioannisj
ioannisj merged commit 72ac3f2 into main Sep 1, 2026
43 checks passed
@ioannisj
ioannisj deleted the fix/release-notify-rejected branch September 1, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants