Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate maskPhotoLibraryImages #321

Merged
merged 5 commits into from
Dec 3, 2024
Merged

fix: deprecate maskPhotoLibraryImages #321

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a75c35b
fix: deprecate maskPhotoLibraryImages
ioannisj Dec 2, 2024
5ec7526
fix: update deprecation message
ioannisj Dec 2, 2024
6250eda
fix: lint
ioannisj Dec 2, 2024
8300aff
chore: revert lint
ioannisj Dec 3, 2024
5d4565b
chore: update changelog
ioannisj Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion posthog-core/test/test-utils/PostHogCoreTestClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ export interface PostHogCoreTestClientMocks {
export class PostHogCoreTestClient extends PostHogCore {
public _cachedDistinctId?: string

constructor(private mocks: PostHogCoreTestClientMocks, apiKey: string, options?: PostHogCoreOptions) {
constructor(
private mocks: PostHogCoreTestClientMocks,
apiKey: string,
options?: PostHogCoreOptions
) {
ioannisj marked this conversation as resolved.
Show resolved Hide resolved
super(apiKey, options)

this.setupBootstrap(options)
Expand Down
4 changes: 4 additions & 0 deletions posthog-react-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Next

# 3.5.0 - 2024-12-02

1. fix: deprecate maskPhotoLibraryImages due to unintended masking issues

# 3.4.0 - 2024-11-26

1. feat: automatically mask out user photos and sandboxed views like photo picker (iOS Only)
Expand Down
2 changes: 1 addition & 1 deletion posthog-react-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "posthog-react-native",
"version": "3.4.0",
"version": "3.5.0",
"main": "lib/posthog-react-native/index.js",
"files": [
"lib/"
Expand Down
2 changes: 1 addition & 1 deletion posthog-react-native/src/posthog-rn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export class PostHog extends PostHogCore {
maskAllTextInputs = true,
maskAllImages = true,
maskAllSandboxedViews = true,
maskPhotoLibraryImages = true,
maskPhotoLibraryImages = false,
captureLog = true,
captureNetworkTelemetry = true,
iOSdebouncerDelayMs = 1000,
Expand Down
4 changes: 3 additions & 1 deletion posthog-react-native/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,9 @@ export type PostHogSessionReplayConfig = {
* Enable masking of images that likely originated from user's photo library
* Experimental support (UIKit only)
* iOS only
* Default: true
* Default: false
*
* @deprecated This property has no effect and will be removed in the next major release. To learn how to manually mask user photos please see our Privacy controls documentation: https://posthog.com/docs/session-replay/privacy?tab=React+Native
*/
maskPhotoLibraryImages?: boolean
/**
Expand Down
Loading