feat(feature-flags): support quota limiting for feature flags #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarticus
changed the title
dmarticus
requested review from
ioannisj
and removed request for
marandaneto
|
let's figure out session recording before merging this btw |
marandaneto
reviewed
Feb 25, 2025
marandaneto
reviewed
Feb 25, 2025
Co-authored-by: Manoel Aranda Neto <[email protected]>
…-ios into feat/quota-limited-flags
I think as it currently stands, session recording will default to enabled if flag is missing. Android has a similar implementation. Not sure I'm reading this correctly, @marandaneto am I missing something? |
marandaneto
reviewed
Feb 26, 2025
i think we have to patch this part if linkedFlag is provided but does not exist within the featureFlags, recordingActive should be false, can you patch this?
|
marandaneto
reviewed
Feb 26, 2025
marandaneto
reviewed
Feb 26, 2025
marandaneto
approved these changes
Feb 26, 2025
Co-authored-by: Manoel Aranda Neto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with PostHog/posthog#28564, we now start to respond different with the /decide APIs if users have gone over their quota limit.