Stop adding local feature flag data to $feature_flag_called event #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not in use.
haacked
force-pushed
the
haacked/some-fixes
branch
from
18b6429 to
4ae592b
Compare
They're just easier to maintain as we add more properties
Want to make sure PostHog.AspNetCore works in this scenario.
Otherwise we can't create an instance of `HttpContextFeatureFlagCache`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PostHog/posthog-python#181 for more context.
Also, remove is_simple_flag from unit tests. It's not used anywhere.