-
Notifications
You must be signed in to change notification settings - Fork 10
feat: allow capture to override timestamp with datetime or datetimeoffset #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
Mind adding a unit test to cover this new behavior? |
Rather than try to extract |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
my previous attempt changed the wrong place but should likely remain.
I am trying to add timestamp override support to .Net from this support ticket.
Other SDK's support sending timestamps as a property instead of using current datetime.