Skip to content

Conversation

darkopia
Copy link
Contributor

@darkopia darkopia commented Aug 26, 2025

my previous attempt changed the wrong place but should likely remain.

I am trying to add timestamp override support to .Net from this support ticket.

Other SDK's support sending timestamps as a property instead of using current datetime.

@darkopia darkopia marked this pull request as ready for review August 26, 2025 23:55
@darkopia darkopia requested a review from haacked as a code owner August 26, 2025 23:55
@dmarticus dmarticus moved this to In Review in Feature Flags Aug 26, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 2 comments

Edit Code Review Bot Settings | Greptile

@haacked haacked changed the title allow capture to override timestamp with datetime or datetimeoffset feat: allow capture to override timestamp with datetime or datetimeoffset Aug 29, 2025
@haacked
Copy link
Collaborator

haacked commented Aug 29, 2025

Mind adding a unit test to cover this new behavior?

@haacked
Copy link
Collaborator

haacked commented Aug 29, 2025

Rather than try to extract timestamp from properties, we should add one or more extension method overrides of Capture to src/PostHog/Capture/CaptureExtensions.cs that takes in a timestamp and passes it along to the properties.

@haacked haacked moved this from In Review to Todo in Feature Flags Sep 10, 2025
@haacked haacked requested a review from a team September 10, 2025 17:30
@posthog-project-board-bot posthog-project-board-bot bot moved this from Todo to In Review in Feature Flags Sep 10, 2025
Copy link
Collaborator

@haacked haacked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@github-project-automation github-project-automation bot moved this from In Review to Approved in Feature Flags Sep 10, 2025
@haacked haacked merged commit aa39c12 into main Sep 10, 2025
9 checks passed
@haacked haacked deleted the timestamp-override-feature branch September 10, 2025 21:33
@github-project-automation github-project-automation bot moved this from Approved to Done in Feature Flags Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants