fix reset session when reset or close are called

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## Next
 
+- fix reset session when reset or close are called ([#97](https://github.com/PostHog/posthog-android/pull/97))
+
 ## 3.1.7 - 2024-02-14
 
 - recording: fix missing windowAttachCount method after minification ([#96](https://github.com/PostHog/posthog-android/pull/96))

posthog/src/main/java/com/posthog/PostHog.kt

@@ -172,7 +172,7 @@ public class PostHog private constructor(
 
                 featureFlagsCalled.clear()
 
-                sessionId = sessionIdNone
+                endSession()
             } catch (e: Throwable) {
                 config?.logger?.log("Close failed: $e.")
             }
@@ -542,6 +542,7 @@ public class PostHog private constructor(
         queue?.clear()
         replayQueue?.clear()
         featureFlagsCalled.clear()
+        endSession()
     }
 
     private fun isEnabled(): Boolean {

posthog/src/test/java/com/posthog/PostHogTest.kt

@@ -850,4 +850,56 @@ internal class PostHogTest {
 
         sut.close()
     }
+
+    @Test
+    fun `does not set session id when reset is called`() {
+        val http = mockHttp()
+        val url = http.url("/")
+
+        val sut = getSut(url.toString(), preloadFeatureFlags = false)
+
+        sut.capture(
+            event,
+            distinctId,
+            props,
+            userProperties = userProps,
+            userPropertiesSetOnce = userPropsOnce,
+            groupProperties = groupProps,
+        )
+
+        queueExecutor.awaitExecution()
+
+        var request = http.takeRequest()
+
+        assertEquals(1, http.requestCount)
+        var content = request.body.unGzip()
+        var batch = serializer.deserialize<PostHogBatchEvent>(content.reader())
+
+        var theEvent = batch.batch.first()
+        assertNotNull(theEvent.properties!!["\$session_id"])
+
+        sut.reset()
+
+        sut.capture(
+            event,
+            distinctId,
+            props,
+            userProperties = userProps,
+            userPropertiesSetOnce = userPropsOnce,
+            groupProperties = groupProps,
+        )
+
+        queueExecutor.shutdownAndAwaitTermination()
+
+        request = http.takeRequest()
+
+        assertEquals(2, http.requestCount)
+        content = request.body.unGzip()
+        batch = serializer.deserialize<PostHogBatchEvent>(content.reader())
+
+        theEvent = batch.batch.first()
+        assertNull(theEvent.properties!!["\$session_id"])
+
+        sut.close()
+    }
 }