Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: device_model and device_name properties were inverted #94

Closed
wants to merge 2 commits into from

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

They now match the taxonomy https://github.com/PostHog/posthog/edit/master/frontend/src/lib/taxonomy.tsx

💚 How did you test it?

fix: device_model and device_name properties were inverted

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review February 8, 2024 14:31
@marandaneto marandaneto requested a review from a team February 8, 2024 14:31
@marandaneto marandaneto marked this pull request as draft February 9, 2024 08:06
@marandaneto marandaneto closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants