chore: set device_type accordingly to Mobile, TV, or Tablet #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
reviewed
Feb 8, 2024
| // Devices in a sane range for phones are considered to be phones. | ||
| "Mobile" | ||
| } else if (diagonalSizeInches > 6.9 && diagonalSizeInches <= 18.0) { | ||
| // Devices larger than a phone and in a sane range for tablets are tablets. |
There was a problem hiding this comment.
Queue some obnoxiously large Samsung phone breaking this rule and falling into tablet mode
There was a problem hiding this comment.
yep, today this is the state of the art of what's a phone and a tablet but it is a floating number and will keep being :(
daibhin
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
chore: set device_type accordingly to Mobile, TV, or Tablet
💚 How did you test it?
running on emulators otherwise we'd have to mock the world.
📝 Checklist