Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clone drawable before using #91

Merged
merged 4 commits into from
Feb 1, 2024
Merged

fix: clone drawable before using #91

merged 4 commits into from
Feb 1, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Feb 1, 2024

💡 Motivation and Context

Screenshot 2024-02-01 at 14 34 16

original drawable was being used to draw the bitmap, the original drawable was mutated due to the size differences

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto changed the title - recording: clone drawable before using fix: clone drawable before using Feb 1, 2024
@marandaneto marandaneto requested a review from a team February 1, 2024 13:36
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marandaneto marandaneto merged commit 9c19c04 into main Feb 1, 2024
5 checks passed
@marandaneto marandaneto deleted the fix/drawable-copy branch February 1, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants