chore: exception autocapture #305
Draft
+260
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ioannisj early feedback is welcomed here, the feat works already |
marandaneto
commented
Oct 15, 2025
Comment on lines
+104
to
+105
| // value is required, using an empty placeholder | ||
| exception["value"] = theThrowable.message ?: "" |
There was a problem hiding this comment.
will undo once PostHog/posthog#39571 lands
marandaneto
commented
Oct 15, 2025
Comment on lines
+120
to
+126
| if (event.isFatalExceptionEvent()) { | ||
| executor.submitSyncSafely { | ||
| flushEventSync(event, true) | ||
| } | ||
| } else { | ||
| executor.executeSafely { | ||
| flushEventSync(event) |
There was a problem hiding this comment.
if its fatal, flush it sync otherwise async
marandaneto
commented
Oct 15, 2025
Comment on lines
+20
to
+23
| internal constructor(config: PostHogConfig, adapterExceptionHandler: UncaughtExceptionHandlerAdapter) { | ||
| this.config = config | ||
| this.adapterExceptionHandler = adapterExceptionHandler | ||
| } |
There was a problem hiding this comment.
2nd ctor to make it testable, tests WIP
Sure. Will do as soon as I'm back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
part of PostHog/posthog#38845
💚 How did you test it?
📝 Checklist