-
Notifications
You must be signed in to change notification settings - Fork 31
feat(server): Send feature flags on event if sendFeatureFlags
is set
#302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dustinbyrne
wants to merge
15
commits into
feat/local-eval
Choose a base branch
from
feat/send-feature-flags
base: feat/local-eval
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans things up for future `onlyEvaluateLocally` config and sending feature flags on capture
Instructions and example for changelogPlease add an entry to the appropriate changelog:
Make sure the entry includes this PR's number. ## Next
- Send feature flags on event if `sendFeatureFlags` is set ([#302](https://github.com/PostHog/posthog-android/pull/302)) If none of the above apply, you can opt out of this check by adding |
4cbbd0e
to
2236ce3
Compare
8479f0f
to
4e410f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 This branch is a work in progress
💡 Motivation and Context
The
sendFeatureFlags
configuration option was not being respected in the server-side SDK. This change makes it functional.💚 How did you test it?
WIP, tests to come
📝 Checklist