Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete queue files if serialization fails #232

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Mar 10, 2025

💡 Motivation and Context

Closes #231

💚 How did you test it?

I cannot reproduce this issue.
I cannot mock the serializer right now, since the catch block already deletes the file, I just did the same if the serializer returns null.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review March 10, 2025 10:22
@marandaneto marandaneto requested a review from ioannisj March 10, 2025 10:22
@marandaneto marandaneto requested a review from ioannisj March 10, 2025 10:33
Copy link

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@marandaneto marandaneto merged commit cffcc11 into main Mar 10, 2025
5 checks passed
@marandaneto marandaneto deleted the chore/delete-file-serialization branch March 10, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flushEvents CPU drain
2 participants