Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: expose getApplicationInfo #187

Merged
merged 2 commits into from
Oct 11, 2024
Merged

chore: expose getApplicationInfo #187

merged 2 commits into from
Oct 11, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

expose getApplicationInfo
less code on the flutter plugin the better
#skip-changelog

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team October 10, 2024 09:00
ioannisj
ioannisj reviewed Oct 10, 2024
View reviewed changes
Copy link

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what is this for?

@marandaneto
Copy link
Member Author

Just curious, what is this for?

remove dupe https://github.com/PostHog/posthog-flutter/blob/e1715271b1011d3daeea04ecf813bd1bbc47982f/android/src/main/kotlin/com/posthog/posthog_flutter/PosthogFlutterPlugin.kt#L41-L55

@marandaneto marandaneto merged commit d770f8b into main Oct 11, 2024
5 checks passed
@marandaneto marandaneto deleted the chore/expose-getApplicationInfo branch October 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioannisj ioannisj ioannisj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @ioannisj