Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recording: react native has window attached but needs view ready callback #180

Merged
merged 2 commits into from
Sep 17, 2024
Merged

recording: react native has window attached but needs view ready callback #180

merged 2 commits into from
Sep 17, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

follow up #179
#skip-changelog
the window is already attached but we don't have the callback yet so we need to allow this

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team September 17, 2024 17:27
marandaneto
marandaneto commented Sep 17, 2024
View reviewed changes
posthog-android/src/main/java/com/posthog/android/replay/PostHogReplayIntegration.kt
}
}
}
addView(view)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the check is done inside addView already

@marandaneto marandaneto merged commit f3b4f5e into main Sep 17, 2024
5 checks passed
@marandaneto marandaneto deleted the fix/rn-window-attached branch September 17, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marandaneto