Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect session replay project settings from app start #177

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Sep 13, 2024

💡 Motivation and Context

Similar to PostHog/posthog-ios#150
If replay is active in the SDK config but disabled in the project settings, a recording would start and would end after ~1s when the decide API finishes.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team September 13, 2024 09:01
@marandaneto marandaneto changed the title fix: cache replay config to survive app restart fix: respect session replay project settings from app start Sep 13, 2024
@marandaneto marandaneto marked this pull request as ready for review September 13, 2024 09:22
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto merged commit b24c896 into main Sep 13, 2024
10 checks passed
@marandaneto marandaneto deleted the chore/cache-replay-config branch September 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants