-
Notifications
You must be signed in to change notification settings - Fork 15
Handle deeply nested exceptions. #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MichaelJRM
wants to merge
16
commits into
PostHog:master
Choose a base branch
from
MichaelJRM:fix/handle_deeply_nested_exceptions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Handle deeply nested exceptions. #31
MichaelJRM
wants to merge
16
commits into
PostHog:master
from
MichaelJRM:fix/handle_deeply_nested_exceptions
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chalice <[email protected]>
* Optionally include error event ID in response * Add test * Fix formatting * Try to fix flake8 conflict
Co-authored-by: Twixes <[email protected]>
* Fix `_get_attr` for validation errors involving ints * Format code * Fix typing
Co-authored-by: Twixes <[email protected]>
DRF's exception handler adds a Retry-After header when handling Throttled and that exception has a wait value. But it doesn't get a chance to if you are using this package. Well, not any more! update mypy handle Throttled exception and add a header when appropriate
Co-authored-by: pauldambra <[email protected]>
* can we update to pytnon 3.10 and django 3.2.18 * ugh, 3.10 as a number becomes 3.1 in CI
…ons' into fix/handle_deeply_nested_exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30