Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

paper-icon-item: do not shrink contentIcon #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KapJI
Copy link

@KapJI KapJI commented Feb 12, 2020

When text in paper-icon-item doesn't fit one line, flex container shrinks contentIcon div which looks bad. This change protects width of contentIcon.

Before:
Screen Shot 2020-02-12 at 12 09 27 AM
Note that text is misaligned.

After:
Screen Shot 2020-02-12 at 1 09 36 AM

@KapJI KapJI requested a review from bicknellr as a code owner February 12, 2020 01:10
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@KapJI
Copy link
Author

KapJI commented Feb 12, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@KapJI
Copy link
Author

KapJI commented Feb 12, 2020

Fixes #71

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants