Address comments from #80 (#81)

* [skip ci] add button id * should not have aria-expanded attribute
PolymerElements · Jan 26, 2018 · 9129010 · 9129010
1 parent 86b5076
commit 9129010
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -12,7 +12,7 @@ collapsable area, not on the area itself. See
 https://www.w3.org/WAI/GL/wiki/Using_aria-expanded_to_indicate_the_state_of_a_collapsible_element#Description
 
 ```html
-<button on-click="toggle">toggle collapse</button>
+<button id="button" on-click="toggle">toggle collapse</button>
 
 <iron-collapse id="collapse">
   <div>Content goes here...</div>

diff --git a/test/a11y.html b/test/a11y.html
@@ -51,7 +51,7 @@
           // aria-expanded should only be set on the button that
           // controls the collapsable area, not on the area itself.
           // See https://www.w3.org/WAI/GL/wiki/Using_aria-expanded_to_indicate_the_state_of_a_collapsible_element#Description
-          assert.isNotOk(collapse.getAttribute('aria-expanded'));
+          assert.isFalse(collapse.hasAttribute('aria-expanded'));
         });
 
         test('set opened to true', function() {