fix: validate deposit wallet batch deadlines#15
Open
suhailkakar wants to merge 2 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes request validation for
execute_deposit_wallet_batch, which can cause previously accepted calls (short/invalid deadlines) to fail fast with exceptions. Scope is limited to deposit wallet batching and is covered by new unit tests.Overview
Adds pre-flight validation in
RelayClient.execute_deposit_wallet_batchto reject non-integer deadlines and enforce a minimum future buffer (MIN_DEPOSIT_WALLET_DEADLINE_BUFFER_SECONDS, set to 300s) before posting the transaction.Updates the deposit wallet execution example to use a longer default deadline (10 minutes), adds unit tests covering valid/invalid/boundary deadlines, and bumps the package version to
0.0.2rc2.Reviewed by Cursor Bugbot for commit 9c306c2. Bugbot is set up for automated code reviews on this repo. Configure here.