Migrate CLOB order submission to SDK v2#67
Open
suhailkakar wants to merge 2 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9bce2b1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Updates trading and on-chain transaction paths (order submission, approvals, CTF ops) and introduces proxy-wallet transaction routing, which could affect signing/tx execution and user funds if misconfigured.
Overview
Migrates the CLI from
polymarket-client-sdktopolymarket_client_sdk_v2(plus updatedalloyfeatures/lockfile deps) and switches CLOB order submission forcreate-order/market-orderto sign then submit viapost_orders.Reworks on-chain flows: adds shared Polygon contract address constants and a
proxyhelper to route transactions either directly or through the Polymarket proxy wallet factory, then updatesapproveand allctfcommands to use ABI-encoded calls and proxy-aware sending. User-facing docs/output are updated accordingly (USDC → pUSD, richer JSON error chains, approval output tweaks, and paginated earnings-markets output).Reviewed by Cursor Bugbot for commit 9bce2b1. Bugbot is set up for automated code reviews on this repo. Configure here.