Skip to content

Migrate CLOB order submission to SDK v2#67

Open
suhailkakar wants to merge 2 commits intomainfrom
suhail/clob-v2
Open

Migrate CLOB order submission to SDK v2#67
suhailkakar wants to merge 2 commits intomainfrom
suhail/clob-v2

Conversation

@suhailkakar
Copy link
Copy Markdown
Member

@suhailkakar suhailkakar commented Apr 28, 2026

Note

Medium Risk
Updates trading and on-chain transaction paths (order submission, approvals, CTF ops) and introduces proxy-wallet transaction routing, which could affect signing/tx execution and user funds if misconfigured.

Overview
Migrates the CLI from polymarket-client-sdk to polymarket_client_sdk_v2 (plus updated alloy features/lockfile deps) and switches CLOB order submission for create-order/market-order to sign then submit via post_orders.

Reworks on-chain flows: adds shared Polygon contract address constants and a proxy helper to route transactions either directly or through the Polymarket proxy wallet factory, then updates approve and all ctf commands to use ABI-encoded calls and proxy-aware sending. User-facing docs/output are updated accordingly (USDC → pUSD, richer JSON error chains, approval output tweaks, and paginated earnings-markets output).

Reviewed by Cursor Bugbot for commit 9bce2b1. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9bce2b1. Configure here.

Comment thread src/commands/mod.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant