This repository was archived by the owner on May 11, 2026. It is now read-only.
deposit wallet init#346
Open
arun-poly wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Introduces a new
SignatureTypeenum value that may affect downstream logic that assumes only types 0–2, potentially impacting order signing/validation flows for clients upgrading.Overview
Adds a new signature mode,
SignatureType.POLY_DEPOSIT_WALLET = 3, documented as ERC-1271isValidSignature()validation with ERC-7739 nested domain wrapping.Updates
examples/signatureTypes.tsto show how to initialize aClobClientfor a Polymarket Deposit Wallet using the new signature type and wallet address.Reviewed by Cursor Bugbot for commit ab376cd. Bugbot is set up for automated code reviews on this repo. Configure here.