This repository was archived by the owner on May 11, 2026. It is now read-only.
fix(http): redact sensitive request config in error logs#328
Open
jasonandjay wants to merge 1 commit into
Open
fix(http): redact sensitive request config in error logs#328jasonandjay wants to merge 1 commit into
jasonandjay wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #327
What changed
err.response.configin HTTP helper error paths.sanitizeAxiosResponseConfig()to only keep safe fields (method,url,timeout).headersandauthare not exposed.Why
The previous error logging could leak authorization material via request config dumps in logs.
Note
Low Risk
Low risk: limits error-log output to a small allowlist and adds a unit test; behavior changes are confined to logging and should not affect request/response handling.
Overview
Updates HTTP helper error logging to stop dumping raw Axios
response.config(which may include auth/headers) and instead log a sanitized subset via newsanitizeAxiosResponseConfig().Adds a unit test to assert only
method,url, andtimeoutare retained and sensitive fields likeheaders/authare excluded.Written by Cursor Bugbot for commit a946e5d. This will update automatically on new commits. Configure here.