Doc/add example signature type2 comment#257
Conversation
LINWANHAW
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds documentation for signature type 2 (Gnosis safe) and corrects a spelling error (UDSC → USDC) in example files.
Key changes:
- Fixed spelling of "USDC" in funder variable comments
- Added documentation comment for signature type 2
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/order.ts | Corrected USDC spelling and added signature type 2 comment |
| README.md | Corrected USDC spelling and added signature type 2 comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| //0: Browser Wallet(Metamask, Coinbase Wallet, etc) | ||
| //1: Magic/Email Login | ||
| //2: Signed by EOAs that own Polymarket Gnosis safes |
There was a problem hiding this comment.
The comment could be simplified for consistency with the existing documentation in examples/signatureTypes.ts. Consider using "Polymarket Gnosis safe" instead of "Signed by EOAs that own Polymarket Gnosis safes" to match the pattern established by the other signature type comments and maintain clarity.
| //2: Signed by EOAs that own Polymarket Gnosis safes | |
| //2: Polymarket Gnosis safe |
|
|
||
| //0: Browser Wallet(Metamask, Coinbase Wallet, etc) | ||
| //1: Magic/Email Login | ||
| //2: Signed by EOAs that own Polymarket Gnosis safes |
There was a problem hiding this comment.
The comment could be simplified for consistency with the existing documentation in examples/signatureTypes.ts. Consider using "Polymarket Gnosis safe" instead of "Signed by EOAs that own Polymarket Gnosis safes" to match the pattern established by the other signature type comments and maintain clarity.
| //2: Signed by EOAs that own Polymarket Gnosis safes | |
| //2: Polymarket Gnosis safe |
Note
Docs/examples updates
signatureTypeoptions by adding comment for type2(EOAs for Polymarket Gnosis safes) inREADME.mdandexamples/order.ts.UDSC->USDCin funding address comments inREADME.mdandexamples/order.ts.Written by Cursor Bugbot for commit 05d92a0. This will update automatically on new commits. Configure here.