Skip to content

Feature/session signer#55

Open
pradeep-selvaraju wants to merge 11 commits intomainfrom
feature/session-signer
Open

Feature/session signer#55
pradeep-selvaraju wants to merge 11 commits intomainfrom
feature/session-signer

Conversation

@pradeep-selvaraju
Copy link
Copy Markdown
Contributor

@pradeep-selvaraju pradeep-selvaraju commented May 1, 2026

Note

Medium Risk
Changes order-signing behavior for SignatureTypeV2.POLY_1271 by introducing an alternate signing path and a new signature encoding, which could break compatibility if the on-chain/off-chain verifier expects a different format.

Overview
Adds optional sessionSigner support that can be passed via ClobClientOptions and is threaded through OrderBuilder/order creation helpers into ExchangeOrderBuilderV2.

For v2 POLY_1271 orders, signing can now use the provided sessionSigner to produce a wrapped/nested signature payload (tagged with SESSION_SIGNER_MAGIC); if absent, it falls back to requiring a viem WalletClient local account, and error messaging is updated accordingly.

Reviewed by Cursor Bugbot for commit 2bb80da. Bugbot is set up for automated code reviews on this repo. Configure here.

@pradeep-selvaraju pradeep-selvaraju requested a review from a team as a code owner May 1, 2026 12:24
Base automatically changed from deposit-wallet to main May 1, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants