Skip to content

Fixes/partner reviews#49

Merged
pradeep-selvaraju merged 8 commits intomainfrom
fixes/partner-reviews
May 7, 2026
Merged

Fixes/partner reviews#49
pradeep-selvaraju merged 8 commits intomainfrom
fixes/partner-reviews

Conversation

@pradeep-selvaraju
Copy link
Copy Markdown
Contributor

@pradeep-selvaraju pradeep-selvaraju commented Apr 28, 2026

Note

Medium Risk
Moderate risk because it changes signature/hash generation to async WebCrypto and updates response typings, which can affect auth and downstream integrations if runtime support or outputs differ.

Overview
Switches cryptographic helpers from Node crypto to async WebCrypto: buildPolyHmacSignature and generateOrderBookSummaryHash now use globalThis.crypto.subtle, making createL2Headers and ClobClient.getOrderBookHash async and updating the example/test call sites accordingly.

Updates API response types to match newer server payloads (optional transactionsHashes, new tradeIDs, builder fee fields, nano timestamps, nullable/optional flags, and BalanceAllowanceResponse.allowances), removes client-side request error logging, bumps package version to 1.0.4, and sets node >=20.10 in package.json.

Reviewed by Cursor Bugbot for commit 27de690. Bugbot is set up for automated code reviews on this repo. Configure here.

@pradeep-selvaraju pradeep-selvaraju requested a review from a team as a code owner April 28, 2026 11:01
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7bb9d85. Configure here.

Comment thread src/signing/hmac.ts
Comment thread src/client.ts
@pradeep-selvaraju pradeep-selvaraju merged commit e4bdef8 into main May 7, 2026
5 checks passed
@pradeep-selvaraju pradeep-selvaraju deleted the fixes/partner-reviews branch May 7, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants