chore: validate prices and tick sizes#39
Open
suhaiIkakar wants to merge 1 commit intoPolymarket:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare price/tick bounds with Big instead of parseFloat to avoid floating-point edge cases in priceValid and
isTickSizeSmaller.
Note
Medium Risk
Changes core order validation comparisons to use big-integer arithmetic instead of
parseFloat, which can alter boundary behavior for prices/tick sizes and impact order submission in edge cases.Overview
Updates tick/price validation to avoid floating-point edge cases by switching
isTickSizeSmallerandpriceValidfromparseFloat-based comparisons tomjs-biginteger(Big) comparisons, including computing the upper bound as1 - tickSizewith arbitrary-precision math.Adds
mjs-bigintegeras a runtime dependency to support these comparisons.Reviewed by Cursor Bugbot for commit 1f53d4c. Bugbot is set up for automated code reviews on this repo. Configure here.