Change variants separator #570
Draft
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently benchbuild uses a comma (
,) to join multiple variants into a string. This can cause issues during compilation of some C/CPP projects when they set linker options.The specific issue arises when using
-Wl,rpath,<Path>to pass an rpath to the linker. As benchbuild automatically creates a new build folder for the project for compilation, the Path can contain commas if the project uses variants.However,
-Wltreats every comma as a separator for inputs to pass on to the linker. The result is a compilation error.I think it would be a reasonable change to switch to a different separator. For now, I use the asterisk in my setup but maybe another separator is better suited (asterisks in names causes some weird behavior with with auto-completion in the command line)