Update FloatingMenu.xaml.cs #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the command on a children is triggered, execute MainButton.OnClickCommand so the menu collapse properly (icon now change to the one as defined as CloseIcon).
Polarts
requested changes
Jun 5, 2020
| @@ -119,7 +119,7 @@ void ArrangeChildren(object sender, EventArgs evt) | |||
| Children[i].Scale = 0.7; | |||
| AbsoluteLayout.SetLayoutBounds(Children[i], new Rectangle(0, (60 * i), 60, 60)); | |||
| Children[i].Rotation = 180; | |||
| ((FloatingButton)Children[i]).ExtraCommand = new Command(() => { Collapse(AnimationTime); }); | |||
| ((FloatingButton)Children[i]).ExtraCommand = new Command(() => { MainButton?.OnClickCommand.Execute(null); }); | |||
There was a problem hiding this comment.
Have you tested this? As far as I remember, if you remove Collapse(AnimationTime) the menu won't collapse when a child is clicked.
Please re-add Collapse(AnimationTime) and confirm that it keeps working as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a children command is triggered, the menu icon does not change.
Why not execute MainButton.OnClickCommand so the menu collapse properly ?
(Sorry, first PR ever so I might be missing something to say)