fix(tasks): prune finished task history#138
Draft
attid wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add automatic retention cleanup for finished background tasks.
Why
Finished task entries (
done,failed,cancelled) were retained indefinitely unless a user manually pressed cleanup in/tasks. Since each entry persists the fulloriginal_prompt, old finished tasks can maketasks.jsongrow without bound.Changes
tasks.finished_retention_hourswith a default of 168 hours.tasks.finished_keep_lastwith a default of 100 finished tasks.runningandwaitingtasks protected from retention cleanup.Validation
uv run pytest tests/tasks tests/test_config.py tests/config -quv run ruff check ductor_bot/config.py ductor_bot/tasks/registry.py ductor_bot/tasks/hub.py tests/tasks/test_registry.py tests/tasks/test_hub.pyuv run mypy ductor_bot