-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIHEDP Notebooks #68
base: main
Are you sure you want to change the base?
LIHEDP Notebooks #68
Conversation
…Energy Density Plasma
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Note: I am interested in pushing some of the content of these notebooks on PlasmaPy. I believe the core functions would need to be extracted and implemented in separate .py files. Hopefully, some of this is of interest to you:
|
I have a question about the difference between Pull Request and Drafts: Can you see Drafts and comment on them? Is it annoying for you if the Pull Request contains code that is quite rough? |
@cmoissar drafts just have a note so we know they aren't ready to review. Absolutely no problem opening a PR even when rough - it allows us to easily see what you're working on and give suggestions. I think adding some functions for LP HEDP and an example notebook that features them would be great! I would do at as 1 PR per function and then 1 PR for the notebook. If you're still interested, you should open those PRs on the main PlasmaPy package. |
Hey @cmoissar, do you mind if I take a stab at implementing the plasma critical density formulary as my first commit? |
Of course not, have at it! |
Thanks for your reply. |
Jupyter Notebooks from a course on Laser Plasma Interaction and High Energy Density Plasma