Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIHEDP Notebooks #68

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmoissar
Copy link
Contributor

Jupyter Notebooks from a course on Laser Plasma Interaction and High Energy Density Plasma

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cmoissar cmoissar marked this pull request as ready for review July 18, 2022 15:06
@cmoissar
Copy link
Contributor Author

Note:

I am interested in pushing some of the content of these notebooks on PlasmaPy.

I believe the core functions would need to be extracted and implemented in separate .py files.

Hopefully, some of this is of interest to you:

@cmoissar
Copy link
Contributor Author

I have a question about the difference between Pull Request and Drafts:

Can you see Drafts and comment on them?

Is it annoying for you if the Pull Request contains code that is quite rough?

@pheuer
Copy link
Member

pheuer commented Aug 7, 2022

@cmoissar drafts just have a note so we know they aren't ready to review. Absolutely no problem opening a PR even when rough - it allows us to easily see what you're working on and give suggestions.

I think adding some functions for LP HEDP and an example notebook that features them would be great! I would do at as 1 PR per function and then 1 PR for the notebook. If you're still interested, you should open those PRs on the main PlasmaPy package.

@JaydenR2305
Copy link
Member

Hey @cmoissar, do you mind if I take a stab at implementing the plasma critical density formulary as my first commit?

@cmoissar
Copy link
Contributor Author

cmoissar commented Aug 8, 2022

Hey @cmoissar, do you mind if I take a stab at implementing the plasma critical density formulary as my first commit?

Of course not, have at it!

@cmoissar
Copy link
Contributor Author

cmoissar commented Aug 8, 2022

@cmoissar drafts just have a note so we know they aren't ready to review. Absolutely no problem opening a PR even when rough - it allows us to easily see what you're working on and give suggestions.

I think adding some functions for LP HEDP and an example notebook that features them would be great! I would do at as 1 PR per function and then 1 PR for the notebook. If you're still interested, you should open those PRs on the main PlasmaPy package.

Thanks for your reply.
I'll (slowly) work on that after my summer break!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants