Fix packet decoding #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the ampersand character was incorrectly used instead of the section sign character, which is clearly the right character according to https://wiki.vg/Server_List_Ping#1.6 . The mistake seems to have been introduced when the source code was first published, but went unnoticed since an older version (which didn't contain the mistake) was published as the final release JAR. See also: PlaceholderAPI#2
SladeHazard
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR does not provide a solution for #2
As explained in #2 (comment), the source code uploaded to this repository differs from the source code that was used to build the JAR file which has been uploaded to eCloud. Commit 0128494 reverts the seemingly accidental change to the source code, which means that the plugin once again works if built from this source code. Commit 2c88195 should contain no behavioral changes to the code, it's just a slight rewrite to improve the clarity, by using hexadecimal notation for magic bytes and adding some comments to explain the code.
I have tested that: