[#81]: compat: add Codex v0.134.0 --profile flag rename coverage#91
Open
delexw wants to merge 1 commit into
Open
[#81]: compat: add Codex v0.134.0 --profile flag rename coverage#91delexw wants to merge 1 commit into
delexw wants to merge 1 commit into
Conversation
Codex v0.134.0 (PRs #23883, #24051, #24055, #24059) renamed --profile-v2 to --profile and removed all legacy profile v1 support. codex-trace is unaffected at the production-code level (it reads JSONL session files only, never invokes codex CLI or reads Codex TOML config). This commit adds test coverage to document the change and verify v0.134.0 sessions parse correctly. Changes: - entry.rs: note v0.134.0 rename in v0.131.0 comment; add three v0.134.0 tests - session.rs: note v0.134.0 rename in v0.131.0 comment; add three v0.134.0 tests - discover.rs: note v0.134.0 rename in v0.131.0 comment; add two v0.134.0 tests Fixes #81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex v0.134.0 (PRs #23883, #24051, #24055, #24059) renamed the
--profile-v2CLI flag to--profileand removed all legacy profile v1 support.codex-trace is unaffected at the production-code level. It reads JSONL session files only — it never invokes the
codexCLI and never reads Codex TOML config. Theprofilefield has been present insession_metapayloads since v0.131.0 and continues to parse correctly under v0.134.0.This PR adds test coverage to document the change and verify that v0.134.0 sessions parse correctly.
Changes
src-tauri/src/parser/entry.rs— updated v0.131.0 comment to note the v0.134.0 rename; added 3 new tests:v0134_session_meta_with_profile_field_does_not_panicv0134_session_meta_without_profile_does_not_panicv0134_all_standard_entry_types_parse_correctlysrc-tauri/src/parser/session.rs— updated v0.131.0 comment; added 3 new tests:v0134_profile_session_parses_correctlyv0134_session_without_profile_parses_correctlyv0134_legacy_profile_v1_absent_does_not_affect_session_parsingsrc-tauri/src/parser/discover.rs— updated v0.131.0 comment; added 2 new tests:discover_sessions_v0134_profile_session_discovered_correctlydiscover_sessions_v0134_no_profile_discovered_correctlyVerification
cargo test)npm test/ vitest)cargo clippy -- -D warnings: cleancargo fmt --check: cleanFixes #81