[#80] test(compat): codex-tui.log opt-in in v0.134.0 does not affect JSONL session parser#90
Open
delexw wants to merge 1 commit into
Open
[#80] test(compat): codex-tui.log opt-in in v0.134.0 does not affect JSONL session parser#90delexw wants to merge 1 commit into
delexw wants to merge 1 commit into
Conversation
… affect JSONL session parser Codex v0.134.0 PR #24081 made `codex-tui.log` opt-in. codex-trace reads session data exclusively from JSONL files at ~/.codex/sessions/ — it does not read the TUI log. The opt-in change therefore has no effect on session parsing or session discovery. Add a regression test in entry.rs that documents this boundary and verifies all four standard JSONL entry types (session_meta, event_msg, response_item, turn_context) continue to parse correctly for v0.134.0 sessions regardless of whether the TUI log is present on disk. Fixes #80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex v0.134.0 (PR #24081 "tui: make
codex-tui.logopt-in") changed the TUI log file from being written unconditionally to requiring explicit opt-in. The file no longer exists at its default path unless the user enables TUI logging.codex-trace reads session data exclusively from JSONL files at
~/.codex/sessions/— it does not readcodex-tui.log. The opt-in change therefore has no effect on session parsing or session discovery.Changes
src-tauri/src/parser/entry.rs— adds regression testv0134_tui_log_opt_in_does_not_affect_jsonl_session_parserthat:codex-tui.logopt-in boundary (codex-trace reads JSONL files, not the TUI log)session_meta,event_msg,response_item,turn_context) parse correctly for v0.134.0 sessions regardless of whether the TUI log is present on diskThis follows the established compat-test pattern used for previous Codex version changes (e.g.
log_db_log_writer_refactor_does_not_affect_jsonl_session_parserfor v0.128.0).Verification
cargo test --lib— 132 tests pass (including newv0134test)cargo clippy -- -D warnings— no warningsnpx vitest run— 128 frontend tests passFixes #80