Support different versions of winit for different backends #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One ongoing struggle with conrod has been ensuring that all backend winit dependencies support the same version of winit so that the `conrod_winit` crate functions could be shared between each of the different backends. Previously, only `glium` and `gfx` backends had to be kept in sync. With the recent addition of the `vulkano` backend the problem is starting to get out of hand. This change moves the `conrod_winit` conversions functions behind public macros, allowing for the user to generate the conversion functions necessary for whatever version of winit they happen to currently have. This is a **breaking change** due to the removal of the `conrod_winit`'s conversion functions and the removal of its `winit` and `conrod_core` crate dependencies. See the updated `conrod_vulkano`, `conrod_glium` and `conrod_gfx` backends and their examples to how to update to this change (required changes should be minor).
|
Travis seems to be failing on a rustc bug on the latest nightly branch - see rust-lang/rust#59502. It looks like there's already a PR up to fix the issue. Otherwise, stable and beta seem to be working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One ongoing struggle with conrod has been ensuring that all backend
winit dependencies support the same version of winit so that the
conrod_winitcrate functions could be shared between each of thedifferent backends. Previously, only
gliumandgfxbackends had tobe kept in sync. With the recent addition of the
vulkanobackend theproblem of keeping all backend winit dependencies up-to-date is
starting to get out of hand.
This change moves the
conrod_winitconversion functions behind publicmacros, allowing for the user to generate the conversion functions
necessary for whatever version of winit they happen to currently have.
This is a breaking change due to the removal of the
conrod_winit'sconversion functions and the removal of its
winitandconrod_corecrate dependencies. See the updated
conrod_vulkano,conrod_gliumandconrod_gfxbackends and their examples to see how to update to this change(required changes should be minor).