-
Notifications
You must be signed in to change notification settings - Fork 5.6k
timeBuzzer - fix variable name #19355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeBuzzer - fix variable name #19355
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
WalkthroughMaintenance update correcting typos in the list-activities action ("Runnint" to "Running", "Ids" to "IDs"), renaming a public property for consistency, and bumping versions of the action metadata (0.0.2 → 0.0.3) and package (0.1.0 → 0.1.1). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
components/timebuzzer/actions/list-activities/list-activities.mjs(3 hunks)components/timebuzzer/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (3)
components/timebuzzer/package.json (1)
3-3: Version bump is consistent with the scope of changesPatch update from
0.1.0to0.1.1matches a small, non-breaking fix in the component; no issues here.components/timebuzzer/actions/list-activities/list-activities.mjs (2)
8-8: Action version bump matches the public API tweakUpdating the action version to
0.0.3correctly reflects the public prop rename and text fixes; nothing else in the action behavior changes.
17-26: Copy / description fixes improve clarity without changing behaviorThe updated descriptions and label (“User IDs”, “Filter by User IDs”, clarified start/end date texts) are consistent with the existing props and don’t alter runtime behavior.
Also applies to: 32-41
michelle0927
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
runningActivitiesis referenced later with the correct name.Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.