-
Notifications
You must be signed in to change notification settings - Fork 60
feat(better-search): readme #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA TODO comment and blank lines were added to the README file. No functional changes or logic modifications are present. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 4❌ Failed checks (3 warnings, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/vendure-plugin-better-search/README.md`:
- Around line 17-18: Replace the JavaScript-style line "// TODO fix everything
below this line" in the README.md with proper Markdown (remove the `//`) and
either delete the vague TODO or replace it with a clear, actionable note
describing what needs updating (e.g., "TODO: update README to document
better-search plugin features and usage – list specific sections to update").
Also update the PR description/title to reflect the actual change (better-search
README) and remove or correct the incorrect reference to Issue `#123` so the PR
only references relevant issues; ensure any TODO references include owner and
acceptance criteria.
| // TODO fix everything below this line | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid comment syntax and PR mismatch.
Three issues:
//is JavaScript syntax, not Markdown. This will display as literal text to users, not as a comment.- The PR objectives reference Issue
#123(Picqer API endpoint changes), but this PR only modifies the better-search README—completely unrelated. - "Fix everything below this line" is vague with no context.
🤖 Prompt for AI Agents
In `@packages/vendure-plugin-better-search/README.md` around lines 17 - 18,
Replace the JavaScript-style line "// TODO fix everything below this line" in
the README.md with proper Markdown (remove the `//`) and either delete the vague
TODO or replace it with a clear, actionable note describing what needs updating
(e.g., "TODO: update README to document better-search plugin features and usage
– list specific sections to update"). Also update the PR description/title to
reflect the actual change (better-search README) and remove or correct the
incorrect reference to Issue `#123` so the PR only references relevant issues;
ensure any TODO references include owner and acceptance criteria.
Description
Large improvement to make the better search plugin yield more relevant results, but also making it more performant to run in Vendure's main API instance.
See
Project Descriptionbelow for extensive documentation of this project.To do before merge
Breaking changes
Example: Graphql field X was removed
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time:
📦 For publishable packages:
package.jsonCHANGELOG.mdProject Description
This plugin offers more intuitive search than Vendure's
DefaultSearchPluginbefore the need of an external platform like TypeSense or ElasticSearch.This plug is meant for small to medium sized shops with up to ~10000 variants.
Analysis & Proof of Concept Phase
Goals
This plugin is not meant to be a replacement for Elasticsearch or Typesense, but rather a lightweight alternative for small- to medium-sized shops. If you want to test if it works for you, give it a try and run the load tests we have included.
Requirements
Approach
Benchmarks