feat: Enable annotation on rendered markdown preview #180
+331
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the ability to select text and add annotations directly on rendered markdown content. Changes: - Add annotationUtils.ts (fuzzy matching & context extraction) - Update ApprovalsAnnotator to use rendered view in Annotate mode - Add handleRenderedSelectionMouseUp for text selection on rendered content - Extend ApprovalComment type with textSelector field Technical approach: - Text-based fuzzy matching with context (prefix/suffix) - Map selected text position to markdown source offsets - Maintain backward compatibility with existing ApprovalComment data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that annotating on rendered markdown could improve the review workflow, so I tried implementing it.
This adds a "Rendered / Source" toggle in Annotate mode, allowing annotation on either view.
If this seems useful, feel free to merge. If not, no worries at all — happy to close this.
Closes #179
Changes
ApprovalsAnnotator.tsxannotationUtils.ts(new)Screenshots
Testing