Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoints for the erc20 name and symbol #71

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Add endpoints for the erc20 name and symbol #71

merged 1 commit into from
Jan 30, 2025

Conversation

virgil-serbanuta
Copy link
Member

No description provided.

sskeirik
sskeirik approved these changes Jan 29, 2025
View reviewed changes
Copy link

@sskeirik sskeirik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We just need to see if a different symbol is chosen for this example coin.

Base automatically changed from ulm-binary-parsing to master January 30, 2025 14:25
@virgil-serbanuta virgil-serbanuta marked this pull request as ready for review January 30, 2025 14:28
@virgil-serbanuta virgil-serbanuta merged commit 3c87fb5 into master Jan 30, 2025
3 checks passed
@virgil-serbanuta virgil-serbanuta deleted the erc20-endpoints-rb branch January 30, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sskeirik sskeirik sskeirik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@virgil-serbanuta @sskeirik