Parse the remaining sections from the binary WASM format #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virgil-serbanuta
changed the title
virgil-serbanuta
force-pushed
the
parse-table
branch
2 times, most recently
from
e3ad34e to
eebb271
Compare
virgil-serbanuta
changed the base branch from
master
to
parse-functions-refactor
virgil-serbanuta
force-pushed
the
parse-table
branch
from
eebb271 to
ba6e74d
Compare
sskeirik
approved these changes
Jan 29, 2025
| syntax DefnResult ::= parseElem1(BytesWithIndex) [function, total] | ||
| | #parseElem1a(BytesWithIndexOrError) [function, total] | ||
| | #parseElem1b(IntsResult) [function, total] | ||
| rule parseElem1(BWI:BytesWithIndex) => #parseElem1a(parseConstant(BWI, b"\x00")) |
There was a problem hiding this comment.
This is a small nit; I would prefer to our existing macro for this constant to help readability a bit.
Also, right now, the macro is called ELT_KIND, but I think it might be better to call it ELT_KIND_FUNCREF --- I didn't pay close enough attention to realize that element kind reduces to a type.
The same applies to the other uses of the zero byte.
virgil-serbanuta
force-pushed
the
parse-table
branch
from
7ccb9fd to
96bf72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62