Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building ulm-wasm using kdist #47

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Building ulm-wasm using kdist #47

merged 5 commits into from
Dec 18, 2024

Conversation

traiansf
Copy link
Member

Building ulm-wasm using kdist (only the K part for now; dependencies are still built through make)

@traiansf traiansf linked an issue Dec 17, 2024 that may be closed by this pull request
Add ulm-wasm as a Target in the kdist plugin #44
Closed
sskeirik
sskeirik approved these changes Dec 17, 2024
View reviewed changes
Copy link

@sskeirik sskeirik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks! If you could take a look at one minor comment, that would be awesome.

pykwasm/src/pykwasm/kdist/wasm-semantics/ulm-wasm.md Show resolved Hide resolved
pykwasm/src/pykwasm/kdist/plugin.py Outdated Show resolved Hide resolved
@traiansf traiansf force-pushed the dev/traiansf/44-ulm-wasm-in-kdist branch from bfc3323 to c4e48c0 Compare December 18, 2024 09:11
@traiansf traiansf merged commit c61db98 into master Dec 18, 2024
1 check passed
@traiansf traiansf deleted the dev/traiansf/44-ulm-wasm-in-kdist branch December 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sskeirik sskeirik sskeirik approved these changes

@virgil-serbanuta virgil-serbanuta Awaiting requested review from virgil-serbanuta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ulm-wasm as a Target in the kdist plugin
2 participants
@traiansf @sskeirik